In API requests if the current user is already authenticated, do not authenticate the user again #7643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves performance. For example
reloadAccess()
can otherwise cause fetching all sites the user has permission to over and over again. Even in a simple report we often do reload the same access > 5 times. Sometimes much more.It should not be done in
reloadAccess()
itself since there are actually reasons when you want to reload the access if though the current user is already authenticated. For example when adding a new site: https://github.com/piwik/piwik/blob/master/plugins/SitesManager/API.php#L564