-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve password reset confirmation mail text #9879
Conversation
@@ -12,7 +12,7 @@ | |||
"LoginOrEmail": "Username or E-mail", | |||
"LoginPasswordNotCorrect": "Wrong Username and password combination.", | |||
"LostYourPassword": "Lost your password?", | |||
"MailPasswordChangeBody": "Hi %1$s,\n\nA password reset request was received from %2$s. To confirm this password change so you can login with your new credentials, visit the following link:\n\n%3$s\n\nNote: this token will expire in 24 hours.\n\nAnd thank you for using Piwik!", | |||
"MailPasswordChangeBody": "Hi %1$s,\n\nA password reset request was received from %2$s. To confirm this password change so you can login with your new credentials, visit the following link:\n\n%3$s\n\nAttention: Changing the password will also change your token_auth. You can look up your new token_auth on your settings page.\n\nNote: this token will expire in 24 hours.\n\nAnd thank you for using Piwik!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we maybe add something like "If you are using your API token in any external applications or for archiving, make sure to update the token as requests to the API will fail otherwise."?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure. Will add that...
…user that token_auth will change aswell
Should we maybe also show a warning here? Eg "Changing your password will also change your API token. This token is used for example in the Piwik Mobile app." or maybe we show it instead in success message? https://github.com/piwik/piwik-ui-tests/blob/master/Login_password_reset_complete.png |
I'm not sure where to change it and if. Just asking :) |
Thought about adding it there, but actually the token is changed when clicking on the link in the mail. |
👍 |
Improve password reset confirmation mail text
FYI: tweaked the message further (for consistency) in 409fb2d |
Improves password reset confirmation mail text to inform user that token_auth will change aswell.
New text will be:
refs #9833