Move dimensions to category Referrers/Acquisition #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diosmosis
approved these changes
Jul 12, 2020
sgiehl
force-pushed
the
changedimensioncategory
branch
from
30eb176
to
bae4c0b
Compare
sgiehl
force-pushed
the
changedimensioncategory
branch
from
bae4c0b
to
641e043
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There is currently a discrepancy between the segment list in segment editor and the dimension list in custom reports.
Custom reports tries to use the display name if there is one defined in a category class. The segment editor simply uses the category defined in the dimensions.
That means we have currently no
Acquisitioncategory in SegmentEditor as it is displayed asReferrersthere. Might be something we could change/improve in core maybe?fixes #23