Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In debug mode, add the possibility to change the debug frame height #1

Closed
tsteur opened this issue Jun 5, 2018 · 2 comments
Closed

In debug mode, add the possibility to change the debug frame height #1

tsteur opened this issue Jun 5, 2018 · 2 comments
Labels
Enhancement New feature or request not-in-changelog
Milestone
Priority Backlog

Comments

@tsteur
Copy link
Member

tsteur commented Jun 5, 2018

It would be great to show an indicator that lets users dynamically change the height of the debug iframe. Using resize:vertical css won't really work as the indicator is shown in the very bottom right and not is not really usable there.
@tsteur tsteur added the Enhancement New feature or request label Jun 5, 2018
tsteur added a commit that referenced this issue Jun 13, 2020
@tsteur
Ensure a date and period is set even if $_POST might be empty
71b1850 
Eg if `$_GET['date']=today` is set, but `$_POST['date] = '';` then it might still trigger an exception like this otherwise:


> There was an error while regenerating container releases: Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information): #0 core/Date.php(148): Piwik\Date::getInvalidDateFormatException(false) #1 /core/Plugin/Controller.php(640): Piwik\Date::factory(false) #2 /core/Plugin/Controller.php(607): Piwik\Plugin\Controller->setGeneralVariablesViewAs(Object(Piwik\View), 'basic') #3 /plugins/TagManager/Controller.php(205): Piwik\Plugin\Controller->setGeneralVariablesView(Object(Piwik\View)) #4 /plugins/TagManager/Controller.php(53): Piwik\Plugins\TagManager\Controller->renderTemplate('@TagManager/deb...') #5 [internal function]: Piwik\Plugins\TagManager\Controller->debug() #6 /var/www/html/core/FrontController.php(590): call_user_func_array(Array, Array) #7 /core/FrontController.php
(165): Piwik\FrontController->doDispatch('TagManager', 'debug', Array) #8 plugins/TagManager/Context/WebContext/JavaScriptTagManagerLoader.php(72): Piwik\FrontController->dispatch('TagManager', 'debug') #9 /plugins/TagManager/Context/WebContext.php(166): Piwik\Plugins\TagManager\Context\WebContext\JavaScriptTagManagerLoader->getPreviewJsContent() #10
@tsteur tsteur mentioned this issue Jun 13, 2020
Merged
@tsteur tsteur added this to the Priority Backlog milestone Aug 3, 2021
@tsteur
Copy link
Member Author

tsteur commented Jul 25, 2022 •
edited

@AltamashShaikh this one is done by now maybe?

@AltamashShaikh
Copy link
Contributor

Yes its merged, closing the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request not-in-changelog
Projects
None yet
Milestone
Priority Backlog
Development

No branches or pull requests
3 participants
@tsteur @justinvelluppillai @AltamashShaikh