Implement versioning for tag, trigger, and variable templates #4
Labels
Comments
tsteur
added a commit
that referenced
this issue
Jun 13, 2020
Eg if `$_GET['date']=today` is set, but `$_POST['date] = '';` then it might still trigger an exception like this otherwise: > There was an error while regenerating container releases: Date format must be: YYYY-MM-DD, or 'today' or 'yesterday' or any keyword supported by the strtotime function (see http://php.net/strtotime for more information): #0 core/Date.php(148): Piwik\Date::getInvalidDateFormatException(false) #1 /core/Plugin/Controller.php(640): Piwik\Date::factory(false) #2 /core/Plugin/Controller.php(607): Piwik\Plugin\Controller->setGeneralVariablesViewAs(Object(Piwik\View), 'basic') #3 /plugins/TagManager/Controller.php(205): Piwik\Plugin\Controller->setGeneralVariablesView(Object(Piwik\View)) #4 /plugins/TagManager/Controller.php(53): Piwik\Plugins\TagManager\Controller->renderTemplate('@TagManager/deb...') #5 [internal function]: Piwik\Plugins\TagManager\Controller->debug() #6 /var/www/html/core/FrontController.php(590): call_user_func_array(Array, Array) #7 /core/FrontController.php (165): Piwik\FrontController->doDispatch('TagManager', 'debug', Array) #8 plugins/TagManager/Context/WebContext/JavaScriptTagManagerLoader.php(72): Piwik\FrontController->dispatch('TagManager', 'debug') #9 /plugins/TagManager/Context/WebContext.php(166): Piwik\Plugins\TagManager\Context\WebContext\JavaScriptTagManagerLoader->getPreviewJsContent() #10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We already have versioning for a regular container / for end user. This issue is more about developers who develop tags, triggers, and variables.
At some point we will be needing versioning for the templates as it will be no longer possible to keep BC for example etc.
It won't be implemented just yet as it is not needed and should be fairly "easy" to be added later. Eg each template can define a version which is by default
1. When a template defines a new version, eg2, then we loadtemplateName.v2.web.jsinstead oftemplateName.v1.web.jsortemplateName.web.js.We save the current version of the template in the
container_tag,container_trigger, ... table and will load the template based on the last saved version.The text was updated successfully, but these errors were encountered: