Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
symbolize_test: account for platforms with ".sdata" small data sections
A handful of ELF targets use a ".sdata" section for small data. The default maximum size of symbols in this section as well as the gcc flag to change that maximum size differ between two targets. On such platforms, if there is no data large enough to exceed the small data limit then the ".data" section will be excluded entirely. This changes the check to ensure that at least one of a ".sdata" section OR a ".data" section is present.
- Loading branch information
cc37c61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @matoro,
Would you mind submitting a PR with this fix to the upstream?
In case you don't have time to do so, I can do it for you. Just let me know.
Thanks in advance!
cc37c61
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Jamim , unfortunately I'm unable to submit any of my fixes to Google projects as I do not have a Google account which is required to sign their CLA nor am I able to obtain one. @thesamesam has proxied some of my PRs before but he's very busy and wasn't able to do this one, so if you could, that would be fantastic.