Skip to content

Commit

Permalink
Improve resiliency of custom attribute parsing (dotnet#101164)
Browse files Browse the repository at this point in the history
  • Loading branch information
MichalStrehovsky authored and matouskozak committed Apr 30, 2024
1 parent 8faae71 commit 006be09
Showing 1 changed file with 7 additions and 0 deletions.
@@ -1,6 +1,7 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

using System;
using System.Collections.Immutable;
using System.Diagnostics;
using System.Reflection.Metadata;
Expand Down Expand Up @@ -151,6 +152,12 @@ private static void AddDependenciesDueToCustomAttributes(ref DependencyList depe
// worth the hassle: the input was invalid. The most important thing is that we
// don't crash the compilation.
}
catch (BadImageFormatException)
{
// System.Reflection.Metadata will throw BadImageFormatException if the blob is malformed.
// This can happen if e.g. underlying type of an enum changes between versions and
// we can no longer decode the custom attribute blob.
}
}
}

Expand Down

0 comments on commit 006be09

Please sign in to comment.