Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document dependencies #78

Merged
merged 1 commit into from
Feb 5, 2021
Merged

Conversation

adamjstewart
Copy link
Contributor

Adding some missing dependencies.

setup.py Show resolved Hide resolved
Copy link
Contributor

@kthyng kthyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me!

@adamjstewart
Copy link
Contributor Author

It looks like the Travis tests are hung. Opening and closing to restart the tests...

@dopplershift
Copy link

Travis-CI has recently started limiting resources for open source projects. Matplotlib itself migrated to GitHub Actions, and this repo probably needs to as well.

@adamjstewart
Copy link
Contributor Author

I would be surprised if this repo exceeded the resource limits, it's not particularly active

@dopplershift
Copy link

Well, they're shared across the org...but I guess with matplotlib itself moving, there are now plenty of resources to go around?

@adamjstewart
Copy link
Contributor Author

Well, Travis finally ran, but it's still erroring out. What do we want to do here?

@adamjstewart
Copy link
Contributor Author

Can we get this merged?

@kthyng
Copy link
Contributor

kthyng commented Feb 4, 2021

I am not clear on protocol. Can I merge this without messing something else up? If so I will do that.

@dopplershift
Copy link

@kthyng This repo is independent of the main matplotlib repo, so as the cmocean maintainer, merge whatever you're happy with.

@kthyng
Copy link
Contributor

kthyng commented Feb 5, 2021

@dopplershift Ah, sorry for the delay then. I figured someone else was deciding.

@kthyng kthyng merged commit 324b702 into matplotlib:master Feb 5, 2021
@kthyng
Copy link
Contributor

kthyng commented Feb 5, 2021

Thanks @adamjstewart!!

@adamjstewart adamjstewart deleted the fixes/deps branch February 5, 2021 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants