-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enh remember the style #16
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
34271f6
ENH: add 'persistent' style manager
tacaswell 39ac3ee
TST: put test coverage back at 100%
tacaswell 42975b7
DOC: added docs for persistent style mapping
tacaswell c3b04f8
DOC: update docs for calling Cyclers
tacaswell 7de18fc
MNT: add 'named' as alias for `[]`
tacaswell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find the overridden
__getitem__
really non-intuitive and would highly recommend using a method for this purpose. Something like:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @pelson. Invoking
y = x[key]
where this is the first timekey
has been seen looks like a mistake; it requires the reader to know too much aboutx
.Further, is the use case for this common enough to require a class? How is it superior from the user's standpoint to assigning
aardvark = next(my_cycler)
as needed? Or using the one line from the initializer,styles = dict(zip(names, my_cycler))
?If you adopt Phil's version, the method could be called
named()
:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the getitem interface as it makes use of the natural value by
key lookup that python provides.
I don't think it is any weirder than a defaultdict. It also allows this
object to be a drop in replacement for a dict anyplace that the user is
currently generating a dict of styles and once used can be converted to a
normal dict with
dd = dict(x)
.I will add an alias named for getitem.
On Wed, Aug 26, 2015, 11:07 AM Phil Elson notifications@github.com wrote: