Remove centering of plot on firefox #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Followup to: afdebbf which didn't have centering for chrome, but did for firefox
|
|
|
Thanks a lot! I'll do a release right away |
|
The visual regression tests were not passing I had to update the references. It looks like this was having an impact on the header position on Chrome? It is unclear to me why it was behaving differently on Firefox vs Chrome. |
|
The remaining failures are unrelated to this PR. I believe we need to do something similar as in bqplot bqplot/bqplot#1440. I'll push another PR for that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to: afdebbf
which didn't have centering for chrome, but did for firefox
cc @martinRenou this shouldn't do anything bad (I think?) and fixes the centering for me on firefox