Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI #1440

Merged
merged 1 commit into from Jan 19, 2022
Merged

Fix CI #1440

merged 1 commit into from Jan 19, 2022

Conversation

martinRenou
Copy link
Member

No description provided.

@martinRenou
Copy link
Member Author

At first I was fixing the CI with setting the env variable: NODE_OPTIONS: --openssl-legacy-provider. But this only fixes the CI, not installing from source on user machine.

The second approach is taken from jupyterlab/jupyterlab#11249

@martinRenou
Copy link
Member Author

meeseeksdev please backport to 0.12.x

@lumberbot-app
Copy link

lumberbot-app bot commented Feb 10, 2022

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 0.12.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -m1 92ff00450ed206ad6ebf1c51a88099a406e154a7
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1440: Fix CI'
  1. Push to a named branch:
git push YOURFORK 0.12.x:auto-backport-of-pr-1440-on-0.12.x
  1. Create a PR against branch 0.12.x, I would have named this PR:

"Backport PR #1440 on branch 0.12.x (Fix CI)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

martinRenou added a commit to martinRenou/bqplot that referenced this pull request Feb 10, 2022
martinRenou added a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant