Make handle_binary compliant with the KernelMessage.IMessage spec #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Jupyterlab v4.0.0a21 the buffers deserialized from a KernelMessage are now of type ArrayBuffer instead of the DataView type handle_binary expects. However, it turns out that the spec for KernelMessage.IMessage has always specifed that buffers could be either an ArrayBuffer or an ArrayBufferView. This commit ensures either type is accepted.
|
|
for more information, see https://pre-commit.ci
martinRenou
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that
ipymplwas failing to display plots on more recent versions of the Jupyterlab 4.0 prereleases. This pull request fixes an issue where thehandle_binaryexpects aDataViewbut new versions of Jupyterlab will pass it anArrayBuffer.Since Jupyterlab v4.0.0a21 the buffers deserialized from a
KernelMessageare now of typeArrayBufferinstead of theDataViewtypehandle_binaryexpects. However, it turns out that the spec forKernelMessage.IMessagehas always specified that buffers could be either anArrayBufferor anArrayBufferView. This commit ensures either type is accepted.