Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make handle_binary compliant with the KernelMessage.IMessage spec #505

Merged
merged 2 commits into from
Dec 19, 2022
Merged

Make handle_binary compliant with the KernelMessage.IMessage spec #505

merged 2 commits into from
Dec 19, 2022

Commits on Dec 19, 2022

  1. Make handle_binary compliant with the KernelMessage.IMessage spec 

    Since Jupyterlab v4.0.0a21 the buffers deserialized from a KernelMessage
are now of type ArrayBuffer instead of the DataView type
handle_binary expects. However, it turns out that the spec for
KernelMessage.IMessage has always specifed that buffers could be
either an ArrayBuffer or an ArrayBufferView. This commit ensures
either type is accepted.
    Matthew Toohey committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    3f253a4 View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    1237eca View commit details
    Browse the repository at this point in the history