Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lines.markerfacecoloralt/mfcalt to rcParams #10790

Closed
kalagau opened this issue Mar 14, 2018 · 10 comments
Closed

Add lines.markerfacecoloralt/mfcalt to rcParams #10790

kalagau opened this issue Mar 14, 2018 · 10 comments
Labels
New feature status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. status: inactive Marked by the “Stale” Github Action topic: rcparams

Comments

@kalagau
Copy link
Contributor

kalagau commented Mar 14, 2018

Bug report

Bug summary

lines has an option to set markerfacecoloralt/mfcalt but that option isn't available via rcParams['lines.markerfacecoloralt']
Code for reproduction

import matplotlib as mpl
mpl.rcparams['lines.markerfacecolor']

Actual outcome

 KeyError: 'lines.markerfacecoloralt'

Expected outcome
The default value of markerfacecoloralt should be returned

Matplotlib version

  • Operating system:Ubuntu 17.1
  • Matplotlib version: 2.1.2
  • Matplotlib backend (print(matplotlib.get_backend())): GTK3Agg
  • Python version:3.6
@kalagau
Copy link
Contributor Author

kalagau commented Mar 26, 2018

Would it be possible to have this confirmed? I would like to start working on this.

@jklymak
Copy link
Member

jklymak commented Mar 26, 2018

I don't think we garauntee that every kwarg will get an rcParam. I don't even know what markerfacecoloralt is supposed to refer to, and the documentation is not much help. I'd have to be convinced this needs to be in the rcParam list, perhaps by someone better dcoumenting what it does and why.

@timhoffm
Copy link
Member

timhoffm commented Mar 26, 2018

There are two-color fill styles for markers:
https://matplotlib.org/gallery/lines_bars_and_markers/marker_fillstyle_reference.html

@jklymak jklymak added this to the v3.0 milestone Mar 26, 2018
@jklymak
Copy link
Member

jklymak commented Mar 26, 2018

Cool. I'd never have gotten there from the docstrings for those params, so labelling as a documentation issue. Regardless, I don't know that this needs an rcParam.

@kalagau
Copy link
Contributor Author

kalagau commented Mar 27, 2018

I was under the impression that adding this would improve consistency. Since there are already rcparams for mfc.

@timhoffm
Copy link
Member

Probably not particularly important, but I don't see why we should leave this out. So +0.5 for adding this.

By the way, am I correct that styles are based on rcParams? If so, +1 for adding. This should be configurable in a style.

@jklymak
Copy link
Member

jklymak commented Mar 27, 2018

I guess you could make that argument. The counter would be that you already have to specify the fillstyle, so specifying the color is hardly onerous.

However, I'd take the slightly longer rcParam list if the same PR also explains properly what these do in the docstring of the parameters. Its completely opque unless you look at the example above.

@tacaswell tacaswell modified the milestones: v3.0, v3.1 Aug 11, 2018
@tacaswell tacaswell modified the milestones: v3.1.0, v3.2.0 Mar 18, 2019
@timhoffm timhoffm modified the milestones: v3.2.0, v3.3.0 Aug 16, 2019
@QuLogic QuLogic modified the milestones: v3.3.0, v3.4.0 May 7, 2020
@QuLogic QuLogic modified the milestones: v3.4.0, v3.5.0 Jan 27, 2021
@QuLogic QuLogic modified the milestones: v3.5.0, v3.6.0 Sep 25, 2021
@QuLogic QuLogic modified the milestones: v3.6.0, v3.7.0 Jul 8, 2022
@QuLogic
Copy link
Member

QuLogic commented Jul 16, 2022

I'm rather confused about what needs to be documented here, as it doesn't seem to be what the title is referencing.

@timhoffm timhoffm changed the title lines.markerfacecoloralt/mfcalt not in rcParams Add lines.markerfacecoloralt/mfcalt to rcParams Jul 17, 2022
@timhoffm
Copy link
Member

This was mislabeled. It's a request to add a new rcParam.

@QuLogic QuLogic modified the milestones: v3.7.0, future releases Jan 26, 2023
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Mar 20, 2024
@github-actions github-actions bot added the status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. label Apr 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New feature status: closed as inactive Issues closed by the "Stale" Github Action. Please comment on any you think should still be open. status: inactive Marked by the “Stale” Github Action topic: rcparams
Projects
None yet
Development

No branches or pull requests

5 participants