Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect processing of plot_args when using data argument #11389

Closed
timhoffm opened this issue Jun 6, 2018 · 3 comments
Closed

Incorrect processing of plot_args when using data argument #11389

timhoffm opened this issue Jun 6, 2018 · 3 comments
Milestone

Comments

@timhoffm
Copy link
Member

timhoffm commented Jun 6, 2018

Bug report

As opposed to dicts, pandas.DataFramse etc. name in container does not check if a field exists in a numpy array. Hence, mustn't do args[1] in data unconditionally on the data type. This was spotted due to the indirectly related warning:

lib/matplotlib/tests/test_axes.py::test_structured_data
  /home/travis/build/matplotlib/matplotlib/lib/matplotlib/axes/_axes.py:52: FutureWarning: elementwise == comparison failed and returning scalar instead; this will raise an error or perform elementwise comparison in the future.
    if (not args[1] in data and

Possible fixes:

@timhoffm timhoffm added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jun 6, 2018
@timhoffm timhoffm added this to the v2.2.3 milestone Jun 6, 2018
@tacaswell
Copy link
Member

I have a memory of a PR special casing structured arrays recently....

@jklymak
Copy link
Member

jklymak commented Jul 16, 2018

@timhoffm is this closed by #10872?

@timhoffm
Copy link
Member Author

Yes, fixed by #10872.

@timhoffm timhoffm removed the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants