get_subplot_params behavior doesn't match docstring

[anntzer]

Extracted from #13105:

In gridspec.py, for the GridSpec class:

    def get_subplot_params(self, figure=None, fig=None):
        """
        Return a dictionary of subplot layout parameters. The default
        parameters are from rcParams unless a figure attribute is set.
        """

but the implementation clearly always drops the figure attributes; IOW it always returns a copy of self completely ignoring figure.

Conversely, GridSpecFromSubplotSpec.get_subplot_params does check for None attributes (but isn't documented to do so).

What a mess, as usual.

[github-actions]

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!