Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve or remove parsing of Tkinter.__version__ required for newer python versions #139

Closed
juliantaylor opened this issue Jun 8, 2011 · 4 comments
Assignees
Milestone

Comments

@juliantaylor
Copy link
Contributor

due to the cpython hg transition the version attribute of tkinter has been removed in python 3 and in the python 2.7 rc1 it does not contain a number anymore.
see http://bugs.python.org/issue12236
http://hg.python.org/cpython/file/f3553d5083f8/Lib/tkinter/__init__.py

This breaks the matplotlib build which parses version and expects a number:

OPTIONAL BACKEND DEPENDENCIES
                libpng: 1.2.44
Traceback (most recent call last):
  File "./setup.py", line 162, in <module>
    if check_for_tk() or (options['build_tkagg'] is True):
  File "/build/buildd/matplotlib-1.0.1/setupext.py", line 832, in check_for_tk
    (Tkinter.__version__.split()[-2], Tkinter.TkVersion, Tkinter.TclVersion))
IndexError: list index out of range
@ddale
Copy link
Contributor

ddale commented Jun 8, 2011

This issue was already addressed in commit 04b4e50 on v1.0.x-maint and 9bcca38 on master. Thank you for the report.

@ddale ddale closed this as completed Jun 8, 2011
@efiring efiring reopened this Jun 9, 2011
@efiring
Copy link
Member

efiring commented Jun 9, 2011

Those commits don't take care of version being missing in py3k. Since master is periodically merged into py3k, I am inclined to fix master to handle the missing version case along with everything else.

@ddale
Copy link
Contributor

ddale commented Jun 9, 2011

My mistake, thanks for catching.

@ghost ghost assigned efiring Jun 15, 2011
@efiring
Copy link
Member

efiring commented Jun 15, 2011

Fixed in master with e4a34df

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants