Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix svg flipping (again) #1691

Merged
merged 2 commits into from Jan 23, 2013
Merged

Fix svg flipping (again) #1691

merged 2 commits into from Jan 23, 2013

Conversation

dmcdougall
Copy link
Member

Fixes #1689.

@dmcdougall
Revert "When using nearest neighbor interpolation and not actually sc…
aaae0bd 
…aling, just copy the data. (Note we don't do this for other kinds of interpolation, because the filtering on those interpolations could have an effect even when not actually scaling.)"

This reverts commit 1c9f9b5.
@dmcdougall
Partial revert of 8c25664
1606edb 
This removes the flipping done in Python and keeps the regression tests.
@dmcdougall dmcdougall mentioned this pull request Jan 21, 2013
Closed
@dmcdougall
Copy link
Member Author

All tests pass locally with python 2.7.

@dmcdougall
Copy link
Member Author

Tests are passing on Travis, too.

@mdboom Is it ok for me to merge this?

@mdboom
Copy link
Member

mdboom commented Jan 23, 2013

Seems ok -- but I'm worried the change in _image.cpp may have a negative impact on other backends. Though I know you've looked into the problem in much greater depth than I have. If all tests are passing, I suspect we're ok on this.

dmcdougall added a commit that referenced this pull request Jan 23, 2013
@dmcdougall
Merge pull request #1691 from dmcdougall/fix_svg_flip2
6b20da4 
Fix svg flipping (again)
@dmcdougall dmcdougall merged commit 6b20da4 into matplotlib:v1.2.x Jan 23, 2013
@dmcdougall dmcdougall deleted the fix_svg_flip2 branch January 23, 2013 18:41
@dmcdougall
Copy link
Member Author

@mdboom It worries me too, but remember that it was a regression from v1.1.1, so I think we're ok. Problems may arise from changes in backends that deal with images in the v1.1.1--v1.2.0 range, but I think I'd rather deal with those piecemeal given the solid ground 1.1.1 gave us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dmcdougall @mdboom