Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type stubs for matplotlib #17991

Closed
tekumara opened this issue Jul 21, 2020 · 4 comments
Closed

type stubs for matplotlib #17991

tekumara opened this issue Jul 21, 2020 · 4 comments

Comments

@tekumara
Copy link

Would be great if matplotlib shipped with type stubs.

@story645
Copy link
Member

The dev team may rivisit now that numpy has types. Is there any argument you'd like to add to the previous discussions #15926 & #13798 ?

@tekumara
Copy link
Author

FYI: pylance ships matplotlib stubs already, but they are proprietary (for now) and may end up in pyright see https://github.com/microsoft/pyright/issues/861

@tacaswell
Copy link
Member

I'm going to close this as we are well aware that type annotations exist and adding them across the library is a bigger project than should be tracked in a single issue. I stand by we should let numpy go through a couple of release cylces with the types before we start to adopt them to let the dust settle a bit.

It is my understanding that the MSFT stubs are auto-generated by walking the code which suggests it is not urgent that we take this on (as the tools that will benefit the most from the stubs can generate their own).

@jakebailey
Copy link

jakebailey commented Feb 23, 2021

It is my understanding that the MSFT stubs are auto-generated by walking the code which suggests it is not urgent that we take this on (as the tools that will benefit the most from the stubs can generate their own).

FWIW, this isn't the case; what's shipped with Pylance I wrote by hand over the course of a weekend conference (this weekend was the anniversary of me writing them, yay); they certainly aren't meant to be proprietary in any sense and will end up in https://github.com/microsoft/python-type-stubs (them not being there is an oversight).

Sorry for bumping an old thread (time flies), I'm just now spending some long-overdue time addressing issues in those stubs and was checking on the state of typing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants