Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file(s) not included in published PyPI package #18296

Closed
johnthagen opened this issue Aug 19, 2020 · 0 comments · Fixed by #18298
Closed

LICENSE file(s) not included in published PyPI package #18296

johnthagen opened this issue Aug 19, 2020 · 0 comments · Fixed by #18298
Milestone

Comments

@johnthagen
Copy link
Contributor

Bug report

Bug summary

A LICENSE file is not included in published PyPI packages. This makes pip-licenses unable to find a license file when generating a license report.

Code for reproduction

$ pip install pip-licenses matplotlib
$ pip-licenses --from=mixed --format=plain-vertical --with-license-file --no-license-path
...
matplotlib
3.3.1
Python Software Foundation License
UNKNOWN
...

Expected outcome

pip-licenses would find a LICENSE file when it inspects the unpacked wheel and print it rather than printing UNKNOWN. Newer versions of setuptools look in the root directory of a project for LICENSE files when they build, but in this project the LICENSE files are in a subdirectory, so they will need to be explicitly added using the license_files option to setuptools.setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants