Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bisect very hard with rcParam changes #19578

Closed
jklymak opened this issue Feb 25, 2021 · 2 comments
Closed

bisect very hard with rcParam changes #19578

jklymak opened this issue Feb 25, 2021 · 2 comments
Milestone

Comments

@jklymak
Copy link
Member

jklymak commented Feb 25, 2021

At some point recently we changed rcParam handling so that it makes git bisect require that matplotlib be rebuilt every time a bisect step crosses a change in the rcParam list. This seems a needless pain, and we should just warn.

  import matplotlib as mpl
Traceback (most recent call last):
  File "/Users/jklymak/matplotlib/testlisted.py", line 1, in <module>
    import matplotlib as mpl
  File "/Users/jklymak/matplotlib/lib/matplotlib/__init__.py", line 833, in <module>
    defaultParams = rcsetup.defaultParams = {
  File "/Users/jklymak/matplotlib/lib/matplotlib/__init__.py", line 836, in <dictcomp>
    rcParamsDefault[key]),
  File "/Users/jklymak/matplotlib/lib/matplotlib/__init__.py", line 621, in __getitem__
    return dict.__getitem__(self, key)
KeyError: 'axes.zmargin'
@tacaswell
Copy link
Member

or at least have MPLBISECT_MODE=1 env?

@anntzer
Copy link
Contributor

anntzer commented Apr 22, 2021

fixed by #19603, I believe.

@anntzer anntzer closed this as completed Apr 22, 2021
@QuLogic QuLogic added this to the v3.5.0 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants