New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make colorbar boundaries work again #21913
Make colorbar boundaries work again #21913
Conversation
d9b1945
to
31efd72
Compare
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
This conflicts with #21137 (on |
Actually, I just looked closer at what that did and I'm just going to backport both at the same time. |
…3.5.x Backport PR #21913 on branch v3.5.x (Make colorbar boundaries work again)
PR Summary
colorbar has a boundaries kwarg, which is supposed to make the colorbar boundaries hard coded. This was broken by the colorbar rewrite.
I actually think this kwarg is a bit of an abomination from a data visualization point of view; if you want discrete colors that is the job of the norm, not the colorbar. But I also admit we can't break it.
Added a new test so we don't break it wantonly again.
PR Checklist
Tests and Styling
pytest
passes).flake8-docstrings
and runflake8 --docstring-convention=all
).Documentation
doc/users/next_whats_new/
(follow instructions in README.rst there).doc/api/next_api_changes/
(follow instructions in README.rst there).