Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT]: requirements/testing/minver.txt could also test oldest-supported pytest version #23154

Closed
anntzer opened this issue May 27, 2022 · 13 comments · Fixed by #25563
Closed
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! Maintenance topic: testing
Milestone

Comments

@anntzer
Copy link
Contributor

anntzer commented May 27, 2022

Summary

pytest.ini claims that we support pytest>=3.6; we could add a version pin in requirements/testing/minver.txt to check that 3.6 is indeed supported (I don't know if that's actually the case!).

Proposed fix

No response

@tacaswell tacaswell added this to the v3.6.0 milestone May 27, 2022
@tacaswell tacaswell added Good first issue Open a pull request against these issues if there are no active ones! Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues labels May 27, 2022
@SaumyaBhushan
Copy link
Contributor

@anntzer Should I add pytest>=3.6; in the requirement.txt file.

@SaumyaBhushan
Copy link
Contributor

Will it work as a solution for this?

@timhoffm
Copy link
Member

If we add the constraint, we should validate that it's correct.

I'm a bit hesitant whether we need that constraint. Lower constraints are increasing from time to time and we won't know that because we don't test with the lowest versions. We would only learn from that if a user (or dev) happens to have such an installation and reports back. Unless somebody does something very specific setting up a new environment from requirements will fetch the most recent version.

@anntzer
Copy link
Contributor Author

anntzer commented May 28, 2022

It should be validated, yes. I don't really mind if we do, but if we don't, we should remove the claimed version bound in pytest.ini.

@QuLogic QuLogic modified the milestones: v3.6.0, v3.6.1 Sep 14, 2022
@QuLogic QuLogic modified the milestones: v3.6.1, v3.6.2 Oct 6, 2022
@shade34321
Copy link

Is all that is needed is to set up a virtual env, ensure pytest 3.6 is installed, and run the tests? If so I think I can do that and would like to work on this for hacktoberfest.

@tacaswell
Copy link
Member

@shade34321 Doing this as on one-off test locally is useful information, however what this issue is proposing is to change the CI configuration so that one of our jobs runs with the version of pytest that we claim is the minimum supported version.

@shade34321
Copy link

That makes more sense! I was curious how just running it once and awhile would be that helpful. Is the proposed solution above of adding it here sufficient? Then fixing anything that is broken or upgrading the min version to something that does work? Regardless it doesn't sound too difficult and would like to work on this if possible.

@QuLogic QuLogic modified the milestones: v3.6.2, v3.6.3 Oct 27, 2022
@QuLogic QuLogic modified the milestones: v3.6.3, v3.7.0 Jan 11, 2023
@QuLogic QuLogic modified the milestones: v3.7.0, future releases Jan 25, 2023
@Shikharishere
Copy link

Is this issue still open??

@tacaswell
Copy link
Member

Yes, I believe so.

@Shikharishere
Copy link

Okayy

@harshvardhan2707
Copy link

So if I understand clearly, just pytest==3.6.0 needs to be inserted here?

@tacaswell
Copy link
Member

Yes.

@aalocked
Copy link

Can I still work on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Difficulty: Easy https://matplotlib.org/devdocs/devel/contribute.html#good-first-issues Good first issue Open a pull request against these issues if there are no active ones! Maintenance topic: testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants