New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT]: requirements/testing/minver.txt could also test oldest-supported pytest version #23154
Comments
@anntzer Should I add pytest>=3.6; in the requirement.txt file. |
Will it work as a solution for this? |
If we add the constraint, we should validate that it's correct. I'm a bit hesitant whether we need that constraint. Lower constraints are increasing from time to time and we won't know that because we don't test with the lowest versions. We would only learn from that if a user (or dev) happens to have such an installation and reports back. Unless somebody does something very specific setting up a new environment from requirements will fetch the most recent version. |
It should be validated, yes. I don't really mind if we do, but if we don't, we should remove the claimed version bound in pytest.ini. |
Is all that is needed is to set up a virtual env, ensure pytest 3.6 is installed, and run the tests? If so I think I can do that and would like to work on this for hacktoberfest. |
@shade34321 Doing this as on one-off test locally is useful information, however what this issue is proposing is to change the CI configuration so that one of our jobs runs with the version of pytest that we claim is the minimum supported version. |
That makes more sense! I was curious how just running it once and awhile would be that helpful. Is the proposed solution above of adding it here sufficient? Then fixing anything that is broken or upgrading the min version to something that does work? Regardless it doesn't sound too difficult and would like to work on this if possible. |
Is this issue still open?? |
Yes, I believe so. |
Okayy |
So if I understand clearly, just |
Yes. |
Can I still work on this issue? |
Summary
pytest.ini claims that we support pytest>=3.6; we could add a version pin in requirements/testing/minver.txt to check that 3.6 is indeed supported (I don't know if that's actually the case!).
Proposed fix
No response
The text was updated successfully, but these errors were encountered: