New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add note in contrib guide admonishing against use of f strings in logs #25080

Closed

jklymak opened this issue Jan 25, 2023 · 1 comment · Fixed by #25081

Labels

Documentation Good first issue

Milestone

Member

jklymak commented Jan 25, 2023 •

edited

Can a note about this be put somewhere on the contributing code page? I worry that this is the type of thing that will get changed in either direction 16 times.

Originally posted by @story645 in #25073 (comment)

jklymak added Documentation Good first issue labels

jklymak modified the milestones: v3.7-doc, v3.8.0

muddi900 mentioned this issue

added a note to avoid f-strings in logging #25081

Merged

6 tasks

rcomer linked a pull request

that will close this issue

added a note to avoid f-strings in logging #25081

Merged

6 tasks

Contributor

neutrinoceros commented Jan 26, 2023

How about using flake8-logging-format ?

jklymak closed this as completed in #25081

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment