Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT]: numdecs parameter in LogLocator #25638

Closed
rcomer opened this issue Apr 6, 2023 · 0 comments · Fixed by #25651
Closed

[MNT]: numdecs parameter in LogLocator #25638

rcomer opened this issue Apr 6, 2023 · 0 comments · Fixed by #25651
Milestone

Comments

@rcomer
Copy link
Member

rcomer commented Apr 6, 2023

Summary

LogLocator takes a parameter numdecs, which is not described in its docstring. I also can't find anywhere the parameter is used in the code.
https://matplotlib.org/devdocs/api/ticker_api.html#matplotlib.ticker.LogLocator

numdec (no s) is used within tick_values, but is calculated when needed

numdec = math.floor(log_vmax) - math.ceil(log_vmin)

Proposed fix

If numdecs really isn't used, maybe remove it. Otherwise describe it in the docstring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants