-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]: Add interpolation_stage selector for images in qt figureoptions #26477
Comments
Good first issue - notes for new contributorsThis issue is suited to new contributors because it does not require understanding of the Matplotlib internals. To get started, please see our contributing guide. We do not assign issues. Check the Development section in the sidebar for linked pull requests (PRs). If there are none, feel free to start working on it. If there is an open PR, please collaborate on the work by reviewing it rather than duplicating it in a competing PR. If something is unclear, please reach out on any of our communication channels. |
Hi, I'm working on this issue as my first contribution to matplotlib. I added the qt selector for interpolation_stage and it appears to be working. However, I currently hardcoded 'data' and 'rgba' as the possible options for the selector and I was wondering what would be the best way to get the option names. The qt_selector for interpolations gets the valid options from matplotlib.image.interpolations_names, but there's no matplotlib.image.interpolation_stages_names. Should it be added? I also saw there's a line in lib/matplotlib/image.pyi:76 stating the possible values for interpolation_stage are 'data', 'rgba' and None, but I'm not sure about how to use it to get those values or if it would be appropriate. Maybe I'm overthinking it and hordcoding is fine as there are only two possible options, I just wanted to make sure it doesn't break if the names changed or more options were to be added in the future. |
Hardcoding should be fine. There are really only two possibilities. |
Hi, |
Hi @AnnaMastori, |
…ector-for-images closes #26477 ENH: Add interpolation_stage in qt figureoptions
Problem
There's already an interactive qt selector for the interpolation method, but not yet for the interpolation_stage, which is just as (if not more) important.
Proposed solution
Add it.
The text was updated successfully, but these errors were encountered: