Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color sequence data for Set2 and Set3 #28000

Merged
merged 1 commit into from Apr 1, 2024

Conversation

lkkmpn
Copy link
Contributor

@lkkmpn lkkmpn commented Apr 1, 2024

PR summary

This PR fixes the color sequence data for the Set2 and Set3 qualitative colormaps in the matplotlib.color_sequences object. They were errorneously assigned to the Set1 sequence data.

PR checklist

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a week or so, please leave a new comment below and that should bring it to our attention. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join us on gitter for real-time discussion.

For details on testing, writing docs, and our review process, please see the developer guide

We strive to be a welcoming and open project. Please follow our Code of Conduct.

Copy link
Member

@rcomer rcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't even know this was a thing...!

@rcomer rcomer added this to the v3.8.4 milestone Apr 1, 2024
@rcomer rcomer merged commit 47dc2c6 into matplotlib:main Apr 1, 2024
39 of 42 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Apr 1, 2024
@rcomer
Copy link
Member

rcomer commented Apr 1, 2024

Thanks @lkkmpn and congratulations on your first PR merged into Matplotlib! I hope we hear from you again.

QuLogic added a commit that referenced this pull request Apr 1, 2024
…000-on-v3.8.x

Backport PR #28000 on branch v3.8.x (Fix color sequence data for Set2 and Set3)
@ksunden ksunden mentioned this pull request Apr 4, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants