Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT]: Essential build requirements not included in dev-requirements #28192

Closed
flaviut opened this issue May 8, 2024 · 0 comments · Fixed by #28091
Closed

[MNT]: Essential build requirements not included in dev-requirements #28192

flaviut opened this issue May 8, 2024 · 0 comments · Fixed by #28091
Milestone

Comments

@flaviut
Copy link

flaviut commented May 8, 2024

Summary

Following the instructions on the dev setup page fails due to these missing dependencies:

$ python -m pip install --verbose --no-build-isolation --editable ".[dev]"
Using pip 24.0 from /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/pip (python 3.12)
Obtaining file:///home/user/dev/matplotlib
  Running command Checking if build backend supports build_editable
  Checking if build backend supports build_editable ... done
...
ModuleNotFoundError: No module named 'mesonpy'

It seems like the CI tasks need to manually install them as well:

python -m pip install --upgrade meson-python numpy pybind11 setuptools-scm

and once they are manually installed locally using python -m pip install meson-python numpy pybind11 setuptools-scm, the build succeeds:

$ python -m pip install --verbose --no-build-isolation --editable ".[dev]"
...
Installing collected packages: matplotlib
  Attempting uninstall: matplotlib
    Found existing installation: matplotlib 3.8.4
    Uninstalling matplotlib-3.8.4:
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/__pycache__/pylab.cpython-312.pyc
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/matplotlib-3.8.4.dist-info/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/matplotlib/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/axes_grid1/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/axisartist/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/mpl_toolkits/mplot3d/
      Removing file or directory /home/user/dev/matplotlib/venv/lib/python3.12/site-packages/pylab.py
      Successfully uninstalled matplotlib-3.8.4
Successfully installed matplotlib-3.10.0.dev168+ga4243d9557

Proposed fix

Update the requirements files to include these dependencies. Update the pipelines to only use the requirements files and not manual pip calls.

@QuLogic QuLogic linked a pull request May 8, 2024 that will close this issue
4 tasks
@QuLogic QuLogic added this to the v3.10.0 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants