Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_log_margins test failure #7452

Closed
Kojoley opened this issue Nov 13, 2016 · 1 comment
Closed

test_log_margins test failure #7452

Kojoley opened this issue Nov 13, 2016 · 1 comment
Assignees
Milestone

Comments

@Kojoley
Copy link
Member

Kojoley commented Nov 13, 2016

It was broken by #7144. The tests passed in the PR because at the point when they were made there was no test_log_margins test (it was restored by #7435).

@Kojoley Kojoley added this to the 2.0 (style change major release) milestone Nov 13, 2016
@efiring
Copy link
Member

efiring commented Nov 13, 2016

I think the solution might be to add an atol=1e-16 argument to the assertion. It looks like the problem is that it is using an atol of 0, which allows for no floating point slop in a comparison to 0.
Or, change each [1, 10] to [10, 100], so that the test values would be (1, 2) instead of (0, 1).
(I haven't tried either of these option.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants