Fix logic error in ScalarMappable.to_rgba #11002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
efiring
approved these changes
Apr 8, 2018
|
I think this is a candidate for backport because it fixes a un-workaroundable bug in 2.2.2. I am not 100% on that, if someone else agrees merge away! |
tacaswell
approved these changes
Apr 9, 2018
|
I actually am 98.5% sure its not a followed code path because of the new clipping for imshow (#10220). 0% codecov isn't very good ;-) (i.e. max(x)>1 is always |
|
This is (for better or worse) a public function, I think the clipping happens when we set the data so using the 'standard' path this won't be hit, but using |
|
Ah, fair enough. OTOH, should it get a test if its public, including one to test if this error is properly called? But happy to see it merged if thats gilding the lily... |
|
This is the sort of bugfix that I think does not warrant a test. |
QuLogic
added a commit
that referenced
this pull request
Apr 10, 2018
Backport PR #11002 on branch v2.2.x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This fixes the logic error described in #10890.