Remove support for bar(left=...) (as opposed to bar(x=...)). #11096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklymak
approved these changes
Apr 21, 2018
| @@ -0,0 +1,5 @@ | |||
| ``bar`` (resp. ``barh``) no longer accepts ``left`` (resp. ``bottom`` as first named argument | |||
There was a problem hiding this comment.
resp??? and missing closing bracket after "bottom"...
There was a problem hiding this comment.
See entry for "resp." at https://en.wikipedia.org/wiki/List_of_mathematical_jargon :-)
Anyways, switched to a simpler wording.
There was a problem hiding this comment.
I am illiterate! And I even did a math degree (at some point, long ago, not very well...)
This was scheduled for 3.0. Some tests implicitly relied on the old
default of 'align="edge"' (via the _classic_test style), they were
manually updated. test_bar{,h}_signature was removed as it doesn't
really serve any purpose anymore.
timhoffm
approved these changes
Apr 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was scheduled for 3.0. Some tests implicitly relied on the old
default of 'align="edge"' (via the _classic_test style), they were
manually updated. test_bar{,h}_signature was removed as it doesn't
really serve any purpose anymore.
PR Summary
PR Checklist