Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dummy_threading if threading not available #11262

Merged
merged 1 commit into from May 17, 2018
Merged

Use dummy_threading if threading not available #11262

merged 1 commit into from May 17, 2018

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented May 17, 2018 •
edited

PR Summary

Uses the dummy_threading module on Python platforms where threading isn't available. It makes the lock essentially a no-op, which is fine for platforms that don't have threading anyway.

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

jklymak
jklymak approved these changes May 17, 2018
View reviewed changes
Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM...

@anntzer
Copy link
Contributor

anntzer commented May 17, 2018

I assume this is for pyodide?
The PR's fine, but note that threadless CPythons will be going away in 3.7 (https://bugs.python.org/issue31370; see also https://mail.python.org/pipermail/python-dev/2017-September/149236.html).

@anntzer anntzer added this to the v3.0 milestone May 17, 2018
@anntzer anntzer merged commit 23c9542 into matplotlib:master May 17, 2018
@mdboom
Copy link
Member Author

mdboom commented May 18, 2018

Oof. Thanks for sharing that thread. I'll probably have to go plead my case over there.

@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 May 19, 2018
@tacaswell
Copy link
Member

tacaswell commented May 19, 2018 •
edited

@meeseeksdev backport to v2.2.x

1 similar comment
@tacaswell
Copy link
Member

@meeseeksdev backport to v2.2.x

@lumberbot-app
Copy link

lumberbot-app bot commented May 19, 2018

There seem to be a conflict, please backport manually

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull request Aug 4, 2018
@anntzer @tacaswell
Merge pull request matplotlib#11262 from mdboom/optional-threading
758bfca 
Use dummy_threading if threading not available
Conflicts:
	lib/matplotlib/backends/backend_agg.py
          - conflicts due to removing __future__ / six on master
@tacaswell
Copy link
Member

backported to v2.2.x as 758bfca

@casatir casatir mentioned this pull request Dec 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mdboom @anntzer @tacaswell @jklymak