Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #11317 on branch v2.2.x #11327

Merged
merged 1 commit into from May 29, 2018

Conversation

lumberbot-app[bot]
Copy link

@lumberbot-app lumberbot-app bot commented May 28, 2018

Backport PR #11317: Improve docstring of Axes.pcolor

@lumberbot-app lumberbot-app bot added this to the v3.0 milestone May 28, 2018
@jklymak jklymak closed this May 28, 2018
@jklymak
Copy link
Member

jklymak commented May 28, 2018

I won't delete yet, but I don't think we are backporting *.py:

https://matplotlib.org/devel/coding_guide.html#branches-and-backports

@timhoffm
Copy link
Member

The no-*py backport does only hold for the branch v2.2-doc. I'm quite strongly for backporting pure docstring. It will be around for quite some time and definitively deserves the docstring improvements.

We can discuss if I should backport this to v2.2.x or v2.2-doc. But I really want to backport this somehow.

@tacaswell tacaswell modified the milestones: v3.0, v2.2.3 May 29, 2018
@tacaswell tacaswell reopened this May 29, 2018
@tacaswell
Copy link
Member

Correct, the no *.py is to the -doc branch.

@jklymak jklymak merged commit 89fc4e4 into v2.2.x May 29, 2018
@jklymak
Copy link
Member

jklymak commented May 29, 2018

OK< I stand corrected!

@QuLogic QuLogic deleted the auto-backport-of-pr-11317-on-v2.2.x branch May 29, 2018 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants