New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve docstring of Axes.pcolorfast #11363
Conversation
lib/matplotlib/axes/_axes.py
Outdated
*X* and *Y* are used to specify the coordinates of the | ||
quadilaterals. There are different ways to do this: | ||
|
||
- Use tuples ``xr=(xmin, xmax)`` and ``yr=(ymin, ymax)`` to define a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PEP8 is mad about the length of this line...
700458c
to
3e14dd2
Compare
pcolorfast has been there for a long time now, and I haven't seen a clamor to remove it. It's an odd method in that it can return any of 3 different objects; but it serves a definite purpose. I believe the contents of the present docstring correctly describe how it works. I would not object to removing the "Experimental" part, but at the same time, there are some things that should be fixed--especially the lack of support for log scales when the intermediate-speed option is invoked. I suspect this would not be terribly hard for someone who understands how the normal image and pcolormesh handle scales, but it's all pretty complicated to try to figure out. Once it is understood, it is probably a matter of adding only a few lines of code to image.PcolorImage. Also, I think that the 3 objects returned by pcolorfast could be made more similar than they are now. (Quadmesh (and pcolormesh) desperately needs some refactoring and reworking also.) |
Thanks @efiring For now, I'd just leave the "Experimental" part. I think it's can be rather confusing to have methods methods ( |
@meeseeksdev backport to v2.2.x |
…n-v2.2.x Backport PR #11363 on branch v2.2.x
PR Summary
As part of #10148: Docstring update for
Axes.pcolorfast
.@efiring since you seem to be the original author, can you tell me something about the current state. Is the experimental statement still true? If so, is that because of the limitations mentioned in the current docs? Are there any known bugs? Are there any plans to make it a full method? Or is this maybe a dead end? Are users supposed to use this instead of
pcolor()
orpcolormesh()
for the cases that are currently supported? Thanks a lot.