plt.box_bug_fix

[fredrik-1]

I found a small bug in plt.box. The toggling didn't work because _string_to_bool changed None to False before the test for None.

edit: I have no idea why codecov/patch complain.

PR Checklist

• Has Pytest style unit tests
• Code is PEP 8 compliant
• New features are documented, with examples if plot related
• Documentation is sphinx and numpydoc compliant
• Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
• Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

[tacaswell]

The reason that codecov is failing as that this code path is not currently tested at all!

Could you add a test in test_pyplot that looks something like

fig, ax = plt.subplots()
# assert frame on
plt.box()
# assert frame off
plt.box()
# assert frame on

?

[timhoffm]

Thanks for finding that bug!

A full test for the box() function would be:

def test_pyplot_box():
    fig, ax = plt.subplots()
    plt.box(False)
    assert not ax.get_frame_on()
    plt.box(True)
    assert ax.get_frame_on()
    plt.box()
    assert not ax.get_frame_on()
    plt.box()
    assert ax.get_frame_on()

Could you please add that to test_pyplot.py? (If not, we can do it later in a separate PR.)

[fredrik-1]

Added the test

[lumberbot-app]

There seem to be a conflict, please backport manually