Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test doc rendering #11595

Closed
wants to merge 2 commits into from
Closed

Conversation

fredrik-1
Copy link
Contributor

@fredrik-1 fredrik-1 commented Jul 7, 2018

Work in progress. I am testing a couple of ways to render the documentation. Issue for discussion appear soon.

Test to see if automodapi are installed on CircleCi and to show the results if it is.

I am testing the transforms module. The result looks ok on my computer.

edit: The same problems with the docstrings with :: in the first line again. I fix it tomorrow.

Ok, automodapi was not installed. I guess that could be fixed by someone. The extension is definitely useful but probable not the best option for all modules.

@ImportanceOfBeingErnest
Copy link
Member

I guess you need to add sphinx-automodapi to the doc-requirements.txt.

@fredrik-1 fredrik-1 force-pushed the test_automodapi branch 3 times, most recently from 7313f0b to c8c0801 Compare July 8, 2018 07:49
@fredrik-1
Copy link
Contributor Author

fredrik-1 commented Jul 8, 2018

So here is the results for the options used. Some comments:

  • I am not sure if attributes should be included in the documentation but I don't think that it exist an option to not include them.
  • Some of the methods appears twice in the methods documentation .
  • Some methods don't have a link to the source code.

update: I saw that it exist a directive automodsumm in automodapi that is supposed to work like autosummary but with automatic rendering. It doesn't seem to work with templates at the moment though but with a few changes I got the expected result. Lets see if it can be fixed in the automodapi module.

I believe that that the automodsumm directive is exactly what we want.

@tacaswell tacaswell added this to the v3.1 milestone Jul 8, 2018
@fredrik-1 fredrik-1 force-pushed the test_automodapi branch 5 times, most recently from 4a5d1e9 to 2f8dd22 Compare July 8, 2018 22:33
@fredrik-1 fredrik-1 force-pushed the test_automodapi branch 2 times, most recently from 2cbc580 to 80fbd53 Compare July 20, 2018 10:12
@fredrik-1 fredrik-1 changed the title test automodapi test doc rendering Jul 20, 2018
@fredrik-1 fredrik-1 force-pushed the test_automodapi branch 4 times, most recently from 7738970 to 1d3cafa Compare July 20, 2018 13:28
@jklymak
Copy link
Member

jklymak commented Feb 9, 2019

I'm closing this, but feel free to re-open if you want to move forward...

@jklymak jklymak closed this Feb 9, 2019
@timhoffm
Copy link
Member

I think some more standard way and improved layout is still needed. OTOH we have different types of code in modules (many small classes, extremely large classes, many module-level functions). They probably need different layouts (as they now more or less manually have).

Not reopening now, but the topic itself is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants