Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress a spurious missing-glyph warning with ft2font. #11605

Merged
merged 1 commit into from Jul 9, 2018
Merged

Suppress a spurious missing-glyph warning with ft2font. #11605

merged 1 commit into from Jul 9, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 9, 2018

FT_Get_Char_Index(face, 0) returns 0; that doesn't warrant a warning.

(aka don't spam the CI with spurious warnings).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Suppress a spurious missing-glyph warning with ft2font.
3ba2e6d 
`FT_Get_Char_Index(face, 0)` returns 0; that doesn't warrant a warning.
@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 9, 2018
@anntzer anntzer added this to the v3.0 milestone Jul 9, 2018
@tacaswell tacaswell merged commit 7684f0f into matplotlib:master Jul 9, 2018
@tacaswell
Copy link
Member

Thanks @anntzer

@anntzer anntzer deleted the spurious-ft2font-missing-glyph-warning branch July 9, 2018 13:28
tacaswell added a commit to tacaswell/matplotlib that referenced this pull request Jul 10, 2018
@tacaswell
Revert "Merge pull request matplotlib#11605 from anntzer/spurious-ft2…
db26adf 
…font-missing-glyph-warning"

This reverts commit 7684f0f, reversing
changes made to 9324b27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anntzer @tacaswell