Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert glyph warnings #11615

Merged
merged 2 commits into from Jul 10, 2018
Merged

Conversation

tacaswell
Copy link
Member

This are producing many warnings on travis, reverting until we sort out why.

…font-missing-glyph-warning"

This reverts commit 7684f0f, reversing
changes made to 9324b27.
…ype-missing-glyphs"

This reverts commit c8a48b8, reversing
changes made to 40cfdae.
@tacaswell tacaswell added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 10, 2018
@tacaswell tacaswell added this to the v3.0 milestone Jul 10, 2018
Copy link
Member

@efiring efiring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It stops the warnings; the Travis failure is unrelated.

@anntzer
Copy link
Contributor

anntzer commented Jul 10, 2018

So the culprit is

def get_char_width(charcode):
where we try to get the widths of all characters in the 0-255 range regardless of whether they exist in the font or not. The correct (and faster) approach is probably to just read the max_advance_width entry in the FT_Face structure (https://www.freetype.org/freetype2/docs/reference/ft2-base_interface.html#FT_FaceRec), but I have no problem with reverting this in the meantime.

Also, it would be nice to clean the warnings that occur during the test run and just make it a failure to have any warning emitted in the test suite (saying this as someone who already spammed the CI twice with repetitive warnings...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants