Don't use Popen(..., shell=True).

[QuLogic]

PR Summary

This is something that bandit complains about with "high" severity, though I don't think it's actually all that severe in this case.

PR Checklist

• Has Pytest style unit tests
• Code is PEP 8 compliant
• [N/A] New features are documented, with examples if plot related
• [N/A] Documentation is sphinx and numpydoc compliant
• [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
• [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

[WeatherGod]

Looks good to me. I agree that it is unlikely anything could go wrong here, but might as well fix it anyway since the shell=True wasn't even needed.

I'll leave separate the question of why we are using Popen, and not something like check_output(), but that can be for a different day.

[timhoffm]

We don't need the shell here.

Note: This could nowadays be written using subprocess.run.

[lumberbot-app]

There seem to be a conflict, please backport manually

[WeatherGod]

so, the conflict is that the v2.2.x code had the string literal wrapped with a str() constructor. Why did we do that?

[QuLogic]

Because Python 2 didn't like Unicode input.

[WeatherGod]

but, where's the unicode? we weren't using unicode literals

…

On Wed, Jul 11, 2018 at 12:38 AM, Elliott Sales de Andrade < ***@***.***> wrote: Because Python 2 didn't like Unicode input. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11624 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-APgSoXM_OGtV7ZnU8LFp_1J5xewks5uFYFVgaJpZM4VKMfX> .

[QuLogic]

We were when the str was added: df27722 ; unicode literals was removed in fa92b90.

[WeatherGod]

ok, then the str() calls aren't needed anymore, that should be simple to fix

…

On Wed, Jul 11, 2018 at 12:59 AM, Elliott Sales de Andrade < ***@***.***> wrote: We were when the str was added: df27722 <df27722> ; unicode literals was removed in fa92b90 <fa92b90> . — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11624 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-FuIUI4tFoWF1SO9CCzH5gr6OPJuks5uFYYUgaJpZM4VKMfX> .