Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For property, use decorator or lambdas. #11698

Merged
merged 1 commit into from Aug 19, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 18, 2018

Replace

def _get_foo(self): ...
foo = property(_get_foo)

by

@property
def foo(self): ...

or

foo = property(lambda self: ...)

(for the one-liner cases, when there are many of them, allowing to block
them together without blank lines in between).

Remove Affine2D.is_separable -- we can just inherit it from
Affine2DBase.is_separable.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Replace
```
def _get_foo(self): ...
foo = property(_get_foo)
```
by
```
@Property
def foo(self): ...
```
or
```
foo = property(lambda self: ...)
```
(for the one-liner cases, when there are many of them, allowing to block
them together without blank lines in between).

Remove Affine2D.is_separable -- we can just inherit it from
Affine2DBase.is_separable.
@tacaswell tacaswell added this to the v3.1 milestone Jul 19, 2018
@dopplershift
Copy link
Contributor

Trying to decide if I should merge this before 3.0 is branched...

@jklymak jklymak merged commit 6fcc530 into matplotlib:master Aug 19, 2018
@anntzer anntzer deleted the propertydecorators branch August 19, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants