Make Poly3DCollection.set_zsort less lenient. #12049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WeatherGod
reviewed
Sep 7, 2018
lib/mpl_toolkits/mplot3d/art3d.py
Outdated
| if zsort is True: | ||
| cbook.warn_deprecated( | ||
| "3.1", "Passing True to mean 'average' for set_zsort is " | ||
| "deprecated; pass 'average' instead.") |
There was a problem hiding this comment.
We should decide when we will remove this. I don't really have a feel for how prevalent this is
There was a problem hiding this comment.
3.3 would be normal.
set_zsort(False) has never worked (it ultimately raises
ValueError('whoops') in `draw()` since mplot3d was first merged in
edd492e), so just don't pretend to support it.
Once support for False is removed, it makes sense to also deprecate
support for True, which was a synonym for 'average', and just accept the
three strings 'average', 'min', and 'max'. And let's not silently drop
invalid strings...
WeatherGod
approved these changes
Sep 7, 2018
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set_zsort(False) has never worked (it ultimately raises
ValueError('whoops') in
draw()since mplot3d was first merged inedd492e), so just don't pretend to support it.
Once support for False is removed, it makes sense to also deprecate
support for True, which was a synonym for 'average', and just accept the
three strings 'average', 'min', and 'max'. And let's not silently drop
invalid strings...
PR Summary
PR Checklist