Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout of HTML animation #12098

Merged
merged 1 commit into from Sep 13, 2018

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Sep 11, 2018

PR Summary

This closes #11795 and superseeds #11816.

Layout changes:

  • Figure is left aligned instead of centered (consistency with static figures).
  • Controls are centered below the figure.
  • Slider length = (roughly) length of button row - exact value may depend on the browser since the slider width is is still hard-coded and the size of the space between the buttons might vary.
  • All buttons have the same size.
  • Adjusted vertical spacing between controls.
  • Labels are now associated with the radio buttons (you can also click on the label instead of the button for selection).

This is how it looks like: (top: old style, bottom: new style)

grafik

grafik

Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up properly with some more detailed CSS. Looks great!

@dstansby dstansby added this to the v3.1 milestone Sep 13, 2018
@mgeier
Copy link
Contributor

mgeier commented Sep 14, 2018

Thanks a lot, that's great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-align animations created with to_jshtml()?
4 participants