Fix travis OSX build #12615
Merged
Fix travis OSX build #12615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now fixes #12578 |
|
Bailing on brew numpy seems a bit drastic. I assume they will fix this eventually....? |
|
What’s the reason we use brew numpy instead of pip? I think there are reasons to use other builds but I would guess most Mac users use conda. |
|
There is something to be said for staying inside of the ecosystem we are using and to avoid hitting pypi. I am pretty confident that this installation issue is going to be transient. |
|
But this makes the board green, so going to merge it :) |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Oct 24, 2018
|
For Python packages I consider PyPI/conda to be the ecosystem we’re working in, NOT homebrew. Do we rely on Ubuntu Numpy packages on Linux? |
jklymak
added a commit
that referenced
this pull request
Oct 24, 2018
…615-on-v3.0.x Backport PR #12615 on branch v3.0.x (Fix travis OSX build)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homebrew numpy seems to be broken, so this just uninstalls it which then lets pip install its own version later in the build. fixes #12578