Be a bit more stringent on invalid inputs. #12627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and give the user fewer ways to shoot themselves in the foot. The change in backend_cairo is on private API; _save is only ever called by the various print_foo methods, with a valid fmt.
anntzer
force-pushed
the
invalid-inputs
branch
from
8ce71f0
to
b98545c
Compare
tacaswell
approved these changes
Oct 25, 2018
jklymak
approved these changes
Oct 25, 2018
timhoffm
approved these changes
Oct 26, 2018
thoo
added a commit
to thoo/matplotlib
that referenced
this pull request
Oct 26, 2018
* upstream/master: Shorten some docstrings. Be a bit more stringent on invalid inputs. (matplotlib#12627) Properly css-style exceptions in the documentation Deprecate passing drawstyle with linestyle as single string. update doc requirement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and give the user fewer ways to shoot themselves in the foot.
The change in backend_cairo is on private API; _save is only ever called
by the various print_foo methods, with a valid fmt.
PR Summary
PR Checklist