Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer log.warning("%s", ...) to log.warning("%s" % ...). #12747

Merged
merged 1 commit into from Nov 5, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 5, 2018

This is suggested by the stdlib docs to avoid paying the cost of the
formatting if the message doesn't actually get emitted. It's marginally
shorter too, especially when ... is surrounded by parentheses.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

This is suggested by the stdlib docs to avoid paying the cost of the
formatting if the message doesn't actually get emitted.  It's marginally
shorter too, especially when ... is surrounded by parentheses.
@anntzer anntzer added this to the v3.1 milestone Nov 5, 2018
@jklymak jklymak merged commit 957fbdb into matplotlib:master Nov 5, 2018
@anntzer anntzer deleted the logformat branch November 6, 2018 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants