Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify stride calculations in loglocator. #12866

Merged
merged 1 commit into from Nov 23, 2018

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 22, 2018

These are just algebraic manipulations:

In classic mode, we want the smallest stride so that

numdec/stride+1 <= numticks

i.e.

stride >= numdec/(numticks-1)

so stride is the ceil() of the RHS (and at least 1, to handle the case
vmin==vmax).

In nonclassic mode, we want the smallest stride so that

numdec//stride+1 <= numticks, i.e. numdec//stride < numticks

(everything is integer), i.e.

numdec < numticks*stride- 1

i.e.

stride > (numdec+1)/numticks

so stride is 1 + the floor() of the LHS.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

These are just algebraic manipulations:

In classic mode, we want the smallest stride so that

    numdec/stride+1 <= numticks

i.e.

    stride >= numdec/(numticks-1)

so stride is the ceil() of the RHS (and at least 1, to handle the case
vmin==vmax).

In nonclassic mode, we want the smallest stride so that

    numdec//stride+1 <= numticks, i.e. numdec//stride < numticks

(everything is integer), i.e.

    numdec < numticks*stride- 1

i.e.

    stride > (numdec+1)/numticks

so stride is 1 + the floor() of the LHS.
@jklymak jklymak merged commit d4b42b6 into matplotlib:master Nov 23, 2018
@anntzer anntzer deleted the logstride branch November 23, 2018 21:11
@QuLogic QuLogic added this to the v3.1 milestone Nov 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants