Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free cart pendulum animation example #13428

Closed
wants to merge 1 commit into from
Closed

Conversation

zjor
Copy link

@zjor zjor commented Feb 13, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@ImportanceOfBeingErnest
Copy link
Member

ImportanceOfBeingErnest commented Feb 13, 2019

Thanks for your pull request. Unfortunately you left the description empty. Can you motivate what you want to add here and why?
There is already an example in the gallery showing a pendulum animation. In how far is this different? Why would we add this example? Does it show anything that is missing in the other example?


On a more formal level, note that `scipy` is not a dependency of matplotlib, so we cannot simply use it as such in examples.

@tacaswell tacaswell added this to the v3.2.0 milestone Feb 14, 2019
@dstansby dstansby added the status: needs clarification Issues that need more information to resolve. label Feb 24, 2019
@jklymak
Copy link
Member

jklymak commented Mar 4, 2019

@zjor thanks for the PR, but I'm inclined to agree w/ @ImportanceOfBeingErnest . Closing for now, but if there is more to this than there appears, then let us know and we can re-open!

@jklymak jklymak closed this Mar 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation status: needs clarification Issues that need more information to resolve.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants