Clarify a bit the implementation of blend_hsv. #13726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introducing additional variables (hue, sat, val) makes it easier to follow what's happening (imo).
timhoffm
approved these changes
Mar 21, 2019
jklymak
reviewed
Mar 23, 2019
| np.putmask(val, intensity > 0, | ||
| (1 - intensity) * val + intensity * hsv_max_val) | ||
| np.putmask(val, intensity < 0, | ||
| (1 + intensity) * val - intensity * hsv_min_val) |
There was a problem hiding this comment.
Are these ops modifying hsv in place? Or do you have to re-assemble hsv?
There was a problem hiding this comment.
This is indeed modifying hsv in place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introducing additional variables (hue, sat, val) makes it easier to
follow what's happening (imo).
PR Summary
PR Checklist