Some more f-strings.

[anntzer]

"..." % locals() is perhaps the construct that f-strings most
obviously replace, so let's do that replacement.

PR Summary

PR Checklist

• Has Pytest style unit tests
• Code is Flake 8 compliant
• New features are documented, with examples if plot related
• Documentation is sphinx and numpydoc compliant
• Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
• Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

[tacaswell]

Do we want to be defensive and keep the formatting information?

[anntzer]

that they're numbers (d) rather than something else? if anything passing the wrong value seems more likely to happen than passing the wrong type.

[timhoffm]

I didn't see that sidelen = 72 is hard coded just a few lines before. So the risk is actually only in a later code change.

[jkseppan]

I think it's a small risk, but it's much easier to debug a Python TypeError than a broken postscript file. Postscript and pdf viewers don't really show very good error messages.

[efiring]

@anntzer I'm neutral with regard to keeping the formatting, but given @tacaswell's question and @timhoffm's response, I suggest you put it in, at which point I will merge. It (the format specs) can't hurt, right?

[anntzer]

I'd rather leave things as they are (we wouldn't be adding that type info if we were writing that code from scratch, after all) but will include the type info if either @tacaswell or @timhoffm reply here that they really want them :)

[timhoffm]

I didn't see that sidelen = 72 is hard coded just a few lines before. So the risk is actually only in a later code change.

[anntzer]

I gave in and added type info :)
Note that previously they were not even present everywhere, e.g. sometimes x and y are %(x)f and sometimes they are %(x)s. I harmonized them to {x:f}.

[jkseppan]

Thanks!