Update qt_compat.py test for already imported binding. #14153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perform proper test.
|
I do not know if this can still make it for 3.1.0 |
anntzer
approved these changes
May 7, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
May 11, 2019
…ported binding.
|
Thanks @vasole ! |
timhoffm
added a commit
that referenced
this pull request
May 12, 2019
…153-on-v3.1.x Backport PR #14153 on branch v3.1.x (Update qt_compat.py test for already imported binding.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform proper test for previous Qt binding import.
PyQt5 can be in sys.modules after an unsuccessful import as described in #14152
closes #14152